Skip to content

Comments

Satisfy linter#3132

Merged
knative-prow[bot] merged 10 commits intoknative:mainfrom
dprotaso:satisfy-linter
Jan 10, 2025
Merged

Satisfy linter#3132
knative-prow[bot] merged 10 commits intoknative:mainfrom
dprotaso:satisfy-linter

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Jan 9, 2025

see individual commits for details

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 9, 2025
@codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.48936% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.30%. Comparing base (23c15c0) to head (69d8f44).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
metrics/memstats.go 89.65% 2 Missing and 1 partial ⚠️
apis/testing/roundtrip/roundtrip.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3132      +/-   ##
==========================================
+ Coverage   78.29%   78.30%   +0.01%     
==========================================
  Files         191      191              
  Lines       11186    11192       +6     
==========================================
+ Hits         8758     8764       +6     
  Misses       2162     2162              
  Partials      266      266

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member Author

dprotaso commented Jan 9, 2025

/assign @skonto

net-contour will work when bump contour and get the newer k8s libs

skonto
skonto reviewed Jan 10, 2025
View reviewed changes
.golangci.yaml

# Checks for pointers to enclosing loop variables.
- exportloopref

Copy link
Contributor

@skonto skonto Jan 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyloopvar could be a replacement. See jaegertracing/jaeger#5976. We also use that in the networking linter.

Copy link
Member Author

@dprotaso dprotaso Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have it already -

pkg/.golangci.yaml

Lines 89 to 90 in b4ff2c1

# Copyloopvar is a linter detects places where loop variables are copied.
- copyloopvar

@skonto
Copy link
Contributor

skonto commented Jan 10, 2025

Let me know if you want to add that linter and I can stamp.

@skonto
Copy link
Contributor

skonto commented Jan 10, 2025

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
@knative-prow
Copy link

knative-prow bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit accfe36 into knative:main Jan 10, 2025
37 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skonto skonto skonto left review comments

@aslom aslom Awaiting requested review from aslom

@evankanderson evankanderson Awaiting requested review from evankanderson

@izabelacg izabelacg Awaiting requested review from izabelacg

Assignees

@skonto skonto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dprotaso @skonto